Skip to content

Resolve open design questions in PLAN.md#83

Open
AneetKaur wants to merge 1 commit into
ed-donner:mainfrom
AneetKaur:docs/plan-review-resolutions
Open

Resolve open design questions in PLAN.md#83
AneetKaur wants to merge 1 commit into
ed-donner:mainfrom
AneetKaur:docs/plan-review-resolutions

Conversation

@AneetKaur

Copy link
Copy Markdown

Folds the doc-review decisions (§13) into the FinAlly spec so the plan is self-consistent before backend/frontend work begins.

Decisions baked in

Decision Where
Removing a held ticker keeps it priced (watchlist ∪ positions) §6 Shared Price Cache, §8 Watchlist
API layer syncs watchlist → source.add_ticker/remove_ticker §6, §8
Main chart accumulated client-side from SSE (resets on refresh, no new endpoint) §10
SSE pushes only on a version change + periodic heartbeats §6 SSE Streaming
Chat loads last 20 messages §9
Rejected trades recorded in actions JSON §7, §9
Sell-to-zero deletes the position row §7, §8
Fractional quantities; shares to 4 dp, cash to cents §8
Startup portfolio snapshot (P&L chart never empty) §7
No-auth /api/chat must not be exposed publicly §11
Massive is a tested-but-secondary path; develop/demo against simulator §12

§13 review items are marked Resolved with pointers to where each landed.

🤖 Generated with Claude Code

Fold doc-review decisions into the spec: priced-ticker set
(watchlist ∪ positions), watchlist↔source sync, SSE push-on-change
plus heartbeats, client-accumulated main chart, 20-message chat
history, rejected trades in actions, sell-to-zero deletes position,
fractional-quantity precision, startup snapshot, and public-exposure
caution. §13 items marked resolved with pointers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants